feat: support compile main-thread script to bytecode in external bundle by upupming · Pull Request #2459 · lynx-family/lynx-stack

upupming · 2026-04-14T08:42:09Z

Summary by CodeRabbit

New Features
- Main-thread scripts in external bundles can be encoded as bytecode.
- Added option to specify which main-thread chunks are encoded.
Tests
- Updated tests to validate bytecode encoding and the custom-section structure of bundle outputs.
Chores
- Added a changeset and bumped encoding-related tooling versions.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

chatgpt-codex-connector · 2026-04-14T08:42:15Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

changeset-bot · 2026-04-14T08:42:18Z

🦋 Changeset detected

Latest commit: a2b7429

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lynx-js/lynx-bundle-rslib-config	Patch
@lynx-js/react-umd	Patch
@lynx-js/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-14T08:42:28Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4b5bf329-db5f-427e-902c-be2d12fe4a13

📥 Commits

Reviewing files that changed from the base of the PR and between 6364902 and 98c0fa6.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

packages/rspeedy/lynx-bundle-rslib-config/package.json
packages/rspeedy/lynx-bundle-rslib-config/test/external-bundle.test.ts
packages/webpack/template-webpack-plugin/package.json

✅ Files skipped from review due to trivial changes (3)

packages/webpack/template-webpack-plugin/package.json
packages/rspeedy/lynx-bundle-rslib-config/package.json
packages/rspeedy/lynx-bundle-rslib-config/test/external-bundle.test.ts

📝 Walkthrough

Walkthrough

Collects main-thread entry chunk names during bundler setup, passes them to ExternalBundleWebpackPlugin via a new mainThreadChunks option, marks matching JS assets for JsBytecode encoding and enables useLepusNG; updates API report, tests, and adds a changeset.

Changes

Cohort / File(s)	Summary
Changeset & API `.changeset/flat-bikes-boil.md`, `packages/rspeedy/lynx-bundle-rslib-config/etc/lynx-bundle-rslib-config.api.md`	Add changeset; API report adds optional `mainThreadChunks?: string[]` on `ExternalBundleWebpackPluginOptions`.
Bundler wiring `packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts`	Merged previous plugins into a single `lynx:external-bundle` plugin, changed signature to accept `{ engineVersion }`, made `api.modifyBundlerChain` async, collect main-thread entry names (`entryName + '.js'`) and pass `mainThreadChunks` to the webpack plugin.
Webpack plugin `packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts`	Extended `ExternalBundleWebpackPluginOptions` with `mainThreadChunks?: string[]`; encode adds `customSections` attribute `'encoding':'JsBytecode'` for matching chunks and sets `useLepusNG: true` in encoder options.
Tests `packages/rspeedy/lynx-bundle-rslib-config/test/external-bundle.test.ts`	Adjusted assertions to validate shapes/types in `decodedResult['custom-sections']`; expect `__main-thread` entries to be encoded (arrays with numeric first element) and retain previous checks for background entries.
Deps `packages/rspeedy/lynx-bundle-rslib-config/package.json`, `packages/webpack/template-webpack-plugin/package.json`	Bumped `@lynx-js/tasm` from `0.0.33` to `0.0.35` in two packages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

feat: Update external bundle mini SDK version to 3.5 and export ExteralValue TS type #2037: Modifies external bundle config and plugin signatures overlapping with engineVersion/target handling.
feat: simplify reactlynx external bundle configuration #2370: Touches lynx-bundle-rslib-config plugin wiring and tests similar to this change.
fix: snapshot not found error when dev with external bundle #2316: Adjusts main-thread runtime/plugin handling and entry behavior relevant to main-thread bundling.

Suggested reviewers

colinaaa
luhc228

Poem

🐰 I nibble at bundles, mark threads with care,
Main ones turn to bytecode, hopping through the air.
Plugins merged, tests checked, small paws on the run,
I tidy chunk names, and then I'm done. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'feat: support compile main-thread script to bytecode in external bundle' directly and clearly summarizes the main objective: adding bytecode compilation support for main-thread scripts in external bundles, which aligns with all key changes across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/external-bundle-mts-bytecode

⚔️ Resolve merge conflicts

Resolve merge conflict in branch feat/external-bundle-mts-bytecode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-14T08:46:02Z

Codecov Report

❌ Patch coverage is 82.66667% with 13 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ndle-rslib-config/src/externalBundleRslibConfig.ts	81.15%	13 Missing ⚠️

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts`:
- Around line 138-142: The check in ExternalBundleWebpackPlugin that uses
this.options.mainThreadChunks?.includes(cur.name) compares against the emitted
asset filename (cur.name) which can include hashes/dirs; change it to compare
normalized chunk/section identity: derive a stable name (e.g., use
cur.chunk?.name or extract a basename/normalized section name from cur.name) and
compare that against a normalized version of this.options.mainThreadChunks (map
the configured names through the same normalization). Update the condition to
use the normalizedChunkName (instead of cur.name) so the JsBytecode branch is
chosen by chunk identity, not the raw emitted filename.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c307d79-ebf4-4bb5-932b-8792c7227ca4

📥 Commits

Reviewing files that changed from the base of the PR and between 7332eb4 and 25f19ff.

📒 Files selected for processing (5)

.changeset/flat-bikes-boil.md
packages/rspeedy/lynx-bundle-rslib-config/etc/lynx-bundle-rslib-config.api.md
packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
packages/rspeedy/lynx-bundle-rslib-config/test/external-bundle.test.ts

codspeed-hq · 2026-04-14T08:58:08Z

Merging this PR will degrade performance by 19.63%

❌ 2 regressed benchmarks
✅ 79 untouched benchmarks
⏩ 26 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`003-hello-list-destroyBackground`	2.8 ms	3.4 ms	-19.26%
❌	`002-hello-reactLynx-destroyBackground`	669.1 µs	832.6 µs	-19.63%

_{Comparing feat/external-bundle-mts-bytecode (a2b7429) with main (e9fe5c5)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-14T08:59:25Z

React Example

#7487 Bundle Size — 224.41KiB (0%).

a2b7429(current) vs 25b09e9 main#7486(baseline)

Bundle metrics no changes

	Current #7487	Baseline #7486
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.51%`	`44.51%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7487	Baseline #7486
IMG	`145.76KiB`	`145.76KiB`
Other	`78.65KiB`	`78.65KiB`

Bundle analysis report Branch feat/external-bundle-mts-bytecod... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T08:59:26Z

Web Explorer

#9061 Bundle Size — 898.15KiB (-0.06%).

a2b7429(current) vs 25b09e9 main#9060(baseline)

Bundle metrics

3 changes

1 regression

	Current #9061	Baseline #9060
Initial JS	`44.47KiB`(`+0.01%`)	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`34.63%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`231`(`+0.43%`)	`230`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.21%`	`27.21%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

2 changes

2 improvements

	Current #9061	Baseline #9060
JS	`494.3KiB` (`-0.03%`)	`494.47KiB`
Other	`401.63KiB` (`-0.1%`)	`402.02KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch feat/external-bundle-mts-bytecod... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T08:59:27Z

React External

#605 Bundle Size — 674.83KiB (+15.7%).

a2b7429(current) vs 25b09e9 main#604(baseline)

Bundle metrics

1 change

	Current #605	Baseline #604
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`98.35%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #605	Baseline #604
Other	`674.83KiB` (`+15.7%`)	`583.28KiB`

Bundle analysis report Branch feat/external-bundle-mts-bytecod... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T08:59:28Z

React MTF Example

#620 Bundle Size — 195.57KiB (0%).

a2b7429(current) vs 25b09e9 main#619(baseline)

Bundle metrics no changes

	Current #620	Baseline #619
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`66`	`66`
Duplicate Code	`44%`	`44%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #620	Baseline #619
IMG	`111.23KiB`	`111.23KiB`
Other	`84.34KiB`	`84.34KiB`

Bundle analysis report Branch feat/external-bundle-mts-bytecod... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…mts-bytecode

feat: support compile main-thread script to bytecode in external bundle

25f19ff

upupming requested review from colinaaa and luhc228 as code owners April 14, 2026 08:42

coderabbitai Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts

upupming added 2 commits April 20, 2026 11:58

Merge branch 'main' into feat/external-bundle-mts-bytecode

5ce3b26

feat: update test

98c0fa6

upupming force-pushed the feat/external-bundle-mts-bytecode branch from 6364902 to 98c0fa6 Compare April 22, 2026 03:31

Merge remote-tracking branch 'origin/main' into feat/external-bundle-…

a2b7429

…mts-bytecode

luhc228 approved these changes Apr 22, 2026

View reviewed changes

upupming merged commit ea5e30e into main Apr 22, 2026
74 of 79 checks passed

upupming deleted the feat/external-bundle-mts-bytecode branch April 22, 2026 06:13

github-actions Bot mentioned this pull request Apr 22, 2026

chore: Release 2026-04-24 04:35:22 #2477

Open

Conversation

upupming commented Apr 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

chatgpt-codex-connector Bot commented Apr 14, 2026

Uh oh!

changeset-bot Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 19.63%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7487 Bundle Size — 224.41KiB (0%).

Uh oh!

relativeci Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9061 Bundle Size — 898.15KiB (-0.06%).

Uh oh!

relativeci Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#605 Bundle Size — 674.83KiB (+15.7%).

Uh oh!

relativeci Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#620 Bundle Size — 195.57KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

upupming commented Apr 14, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Apr 14, 2026 •

edited

Loading

coderabbitai Bot commented Apr 14, 2026 •

edited

Loading

codecov Bot commented Apr 14, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 14, 2026 •

edited

Loading

relativeci Bot commented Apr 14, 2026 •

edited

Loading

relativeci Bot commented Apr 14, 2026 •

edited

Loading

relativeci Bot commented Apr 14, 2026 •

edited

Loading

relativeci Bot commented Apr 14, 2026 •

edited

Loading